Repository navigation
fix: preserve possible file writes from failed commands - #453
Merged
Merged
Conversation
…itles at a word break (#280) The CF-7 close-out's live runs left three observations. This fixes all three. - A Claude shell redirect rewrote a file the map listed only as "read", and a Codex `perl -pi` edit, parsed as an unknown action, left the note with no files section. The context map now lists such commands, once, under "These commands may have changed files that neither the CLI nor Modex named". It uses the rule that already makes a check stale and guesses no file. The footer and Task view read "N, maybe more" or "not listed". Older saved records reopen unchanged. - A thread named after its opening message is cut at a word break, by grapheme, with "…". A Retry still renames a first turn that carries the older 60-character cut. Unit, runner, title and e2e regressions cover each; docs/task-context.md, the close-out receipt and docs/status.md are updated. Val's human review on #280 stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 30, 2026
This was referenced Oct 30, 2026
This was referenced Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shell command can change files and then exit unsuccessfully. The context map previously discarded such commands, so a saved task note could imply that no files were affected. This preserves failed possible-writer commands in the uncertainty list without inventing file paths; denied commands remain excluded.
Unit coverage checks the context map and saved note, and footer E2E coverage exercises a command that writes before exiting 1. This branch integrates main through #458, including the landed parent #450, auxiliary tests #447, iPhone focus correction #455 and Linux baseline correction #456. The integration leaves the correction and its regression tests unchanged; the documentation conflict retains both status entries and records landed diagnostics.
Current head 5a75b2f passed pnpm build and pnpm test: 2,272 passed, 26 skipped, zero failures. Fresh hosted checks are pending. Independent review of the combined parent #450 and correction found no actionable findings; subsequent integrations preserve the correction and incorporate already landed changes.
Historical validation at 7639cc6: hosted CI run 41049616054 passed, with 479 desktop tests, 4 skipped, 7 site tests and passing iPhone checks. Windows job 124042136261 passed. Linux job 124042135855 failed before app launches because Ubuntu 26.04 installed KWallet6 instead of the documented KWallet5 daemon. The failure and artifact remain preserved. #456 landed the qualified Ubuntu 24.04 baseline; Ubuntu 26/KWallet6 acceptance remains open.
Historical failures remain recorded: iPhone job 124022084672 at 1a03a9a failed secure-answer keyboard focus; #455 subsequently landed its focus-wait correction. The first #456 queue run 41056164788 failed the unchanged 500 ms cold-transcript budget with a 781.9 ms median. Its later queue run 41078340820 passed at 394.7 ms and merged; that passing run does not establish the cause of the first failure. #458 landed memory diagnostics without changing the budget.
The earlier full local E2E run passed 476 desktop tests and 7 site tests. These historical results do not replace current-head hosted validation. Native-provider and human acceptance remain separate; #280 stays open.