Repository navigation
test: wait for secure answer field keyboard focus - #455
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 4 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paired iPhone test could try to type a secret after a tap failed to give its secure field keyboard focus. Waiting for any keyboard did not establish that field’s readiness; hosted #453 job 124022084672 failed at this boundary.
Extracts the existing bounded focus wait used by ordinary text entry and reuses it for secure-answer entry before sending keystrokes. Masked-character count, exact secret delivery and transcript no-leak assertions remain intact. Application behavior, test selection and timeout scale are unchanged.
Validation: pnpm build and pnpm test passed (2,268 passed, 26 skipped, zero failures); all 43 native UI tests and 60 native unit tests passed on a dedicated iPhone 17 / iOS 27 simulator. Independent read-only review found no actionable findings. The original hosted iOS 26.4.1 failure remains preserved, and local success does not establish hosted or physical-phone acceptance.
The native unit command initially stopped before tests because its generated Xcode project referenced the temporary pairing file removed by the completed E2E script. Regenerating the project corrected the setup, and the unchanged unit suite passed. Both outcomes are recorded in the review evidence. The existing any-keyboard compatibility fallback, used only when XCTest does not expose field-specific focus, remains an explicit validation limit.