Repository navigation
ci: pin the qualified KWallet5 acceptance baseline - #456
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 4 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 30, 2026
This was referenced Oct 31, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The moving ubuntu-latest runner selected Ubuntu 26.04 for #453, where installing libkf5wallet-bin pulled in KWallet6 and provided no kwalletd5. The existing KWallet5 acceptance harness therefore failed before any wallet-backed app launch. The earlier passing job used Ubuntu 24.04 with the same acceptance scripts.
Pins the native CLI/installer workflow to Ubuntu 24.04, matching its documented KWallet5 scope. All CLI, package, encryption, restart and exact daemon-ownership assertions remain required. The release workflow reuses this workflow. Ubuntu 26/KWallet6, full graphical sessions and real account acceptance remain explicitly unverified; the original failure is preserved.
Validation: pnpm build and pnpm test passed (2,268 passed, 26 skipped, zero failures). Independent read-only review found no actionable findings and confirmed that the pin matches the declared scope. Hosted Linux and Windows native acceptance passed on this exact candidate. The Linux receipt confirms KWallet5 5.115.0-0ubuntu3 and successful write, app-restart and daemon-restart launches. Head CI also passed: 479 desktop tests with 4 skips, 7 site tests, and 43 iPhone UI tests. The distro pin does not freeze apt packages or the runner image revision, so their versions remain part of each acceptance receipt.
Merge-queue validation remains unresolved: run 41056164788 at b033809 failed the approved 500 ms cold-transcript gate with a 781.9 ms median (samples 781.9, 1022.5, 822.3, 719.5 and 729.4 ms). Desktop results were 478 passed, 4 skipped and 1 failed; site tests did not run. The original log, trace archive and all five measurements are retained. Local CPU profiling on an M5 Max did not reproduce the hosted slowdown and does not clear this failure. A later queue run 41078340820 was initiated under BunsDev on 2026-10-30 at 15:11 UTC against current main; it is running. This session did not request that requeue. The earlier failure remains on record and its cause is unresolved.