Skip to content

fix(release): GoReleaser templates without the Pro-only isEnvSet - #121

Merged
coyl merged 1 commit into
mainfrom
fix/goreleaser-oss-templates
Oct 24, 2026
Merged

coyl merged 1 commit into
mainfrom
fix/goreleaser-oss-templates

Conversation

@coyl

@coyl coyl commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

The v1.3.0 release failed in GoReleaser's Homebrew step: function "isEnvSet" not defined. isEnvSet is a GoReleaser Pro template function. It went unnoticed in 1.2.0 because HOMEBREW_TAP_TOKEN was unset and the upload was skipped; with the secret set, the token template is applied and fails. The 1.3.0 GitHub release with its binaries went out, but the images, the chart and the formulas did not.

  • token, skip_upload and notarize enabled now use index .Env "…". Checked with GoReleaser v2.19.0 (the version CI uses) for a set, an empty and an unset variable; goreleaser check passes apart from the existing brews deprecation.
  • CHANGELOG: a Fixed entry. 1.3.1 follows in its own release PR. v1.3.0 is not re-tagged: the Go module proxy may already hold it.

With HOMEBREW_TAP_TOKEN set, the formula step applied isEnvSet, which the
open-source GoReleaser lacks, and the 1.3.0 release stopped before images,
chart and formulas. index .Env gives the same answers (checked with
v2.19.0 for a set, empty and unset variable).
@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 24, 2026, 6:58 PM

@coyl
coyl merged commit eed1221 into main Oct 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant