Repository navigation
fix(conformance): batch D services to 100%; model-aware round-trip echo - #2728
Merged
Merged
Conversation
Real behavior behind failing conformance variants hidden by the stale baseline tolerance: - apigateway: UpdateAccount accepts only the modeled patch paths, validated as a batch before applying. - ec2: CreateImage BootModeOverride; interruptible capacity reservation allocations implemented (create/update/cancel/split interplay). - ecs: daemon task definitions keep pidMode/ipcMode; Describe returns daemonTaskDefinitionArn/deleteRequestedAt. - iam: SimulateCustom/PrincipalPolicy honor ResourcePolicy, ResourceOwner, resource-ARN accounts, caller account, paging. - iotwireless / pinpoint: list ops return the list shapes. - opensearch: empty domain-info container echoed faithfully. - cognito-idp: three implemented ops registered in supported_actions. - appconfig / sagemaker: placeholder extension params and DescribeCluster instance groups use their output shapes. - conformance: follow-up Get shape errors fail round-trip variants; echo comparison is model-aware (only declared output members may be added); no round-trip variants across differing element shapes; documented EC2 IPAM and EventBridge ValidationException error codes allowed.
vieiralucas
force-pushed
the
fix/conformance-batch-d
branch
from
October 16, 2026 21:18
8c49698 to
24e9edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of restoring true 100% Smithy conformance (main's probe: 256,922/257,391; the baseline check only fails a service >100 below its recorded count, so these were hidden). No baseline or doc counts change here (re-recorded for all services in a final PR).
Service fixes
replace /cloudwatchRoleArnandadd/remove /features(UsagePlans) are accepted, the batch is validated before anything applies,BadRequestExceptionotherwise.BootModeOverride(uefi). CreateInterruptibleCapacityReservationAllocation / Update were stubs returning input and an invalidspottype; now real: the source must be active with no end date and enough capacity, capacity moves to a newadhocinterruptible reservation,ZeroSizePreferenceis honored, shrinking reclaims available then in-use instances (per the AWS guide), cancelling either side returns capacity and cancels the allocation, splitting doesn't copy allocation fields. IPAM ops' AWS not-found codes (InvalidIpamId.NotFound,InvalidIpamResourceDiscoveryId.NotFound) allowed for the ec2 entry.pidMode/ipcMode; Describe returnsdaemonTaskDefinitionArn/deleteRequestedAt(the SDK couldn't read the ARN before) and drops undeclaredtags.ValidationException(allowed for events).ResourcePolicy(needs a caller; PolicySourceArn only stands in when it's a user),ResourceOwner/ resource-ARN accounts for cross-account evaluation, the caller's own account,ResourceHandlingOption, andMaxItems/Markerpaging.supported_actions(), so never probed (+104 variants).Parameters; sagemaker DescribeCluster returns instance-group details (Current/TargetCount, MinCount, current/desired image, Status) instead of echoing the create spec.Conformance tool
HostedZoneId); maps need the same keys, lists the same length, unions/scalars exact.Global probe delta (branch base vs branch, every service, containers disabled): 256,943/257,391 -> 257,211/257,387.
RDS CreateDBInstance stays at 5537/5539: its documented example expects success, but the probe runs with containers disabled and RDS refuses creates without a runtime (#2107).
Test plan