[hivecommons-hive]

Test Improvement

#281 added the scroll-behavior: smooth → @media (prefers-reduced-motion: no-preference) rule as an inline loop inside the live style.css test. This PR brings it in line with the other 18 rules in scripts/style-contract.test.mjs:

• extracts it into export function unguardedSmoothScroll(css, label = "css"), returning one problem per unguarded declaration with its line
• runs it over every linked stylesheet and every page's inline <style> (15 pages), like the structure / var() / url() rules
• adds two fixture self-tests: the passing shapes (guarded, nested @supports, auto, vendor-prefixed, commented-out, empty) and each rejection arm (unguarded, reduce guard, wrong media feature, @supports instead of @media, !important, upper-case, block-final without ;, mixed guarded/unguarded with line numbers)
• closes the loopholes the fixtures expose: smooth !important, a last-in-block declaration without a trailing ;, and SMOOTH all passed the inline version silently

Verification at b649779: node --test scripts/*.test.mjs → 785/785 pass (was 769); reverting the #281 style.css change still fails the live rule at line 92; the coverage-floor gate stays green. No production files touched.

Closes #282

---

Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

One verified false negative in the new rule; everything else checks out. Ran node --test scripts/style-contract.test.mjs at 51d4954: 61/61 pass, and the live style.css:93 guard is correctly accepted.

Finding (correctness, low — test-only, live CSS unaffected)

scripts/style-contract.test.mjs:439-447 — when scroll-behavior: is matched inside an @supports prelude, the value scan runs forward to the first ; or } and so passes straight through the { tokens; i = end - 1 then skips them, and the preludes stack never records those blocks. Consequence: an unguarded declaration nested under a feature query is never examined.

unguardedSmoothScroll(`@supports (scroll-behavior: smooth) { html { scroll-behavior: smooth; } }`)
// → []   (should be one problem at line 1)

The fixture at :550 (@media (…no-preference) { @supports (scroll-behavior: smooth) { … } }) passes for the wrong reason — the inner declaration is skipped, not judged guarded — so the self-test does not catch this.

Fix (one token): stop the value scan at { as well, so a prelude match yields a non-smooth value and the following { is tracked normally:

while (end < clean.length && clean[end] !== ";" && clean[end] !== "}" && clean[end] !== "{") end++;

Verified locally: with that change the case above reports css line 1: …, the guarded-@supports fixture still passes, and the file stays 61/61. Worth adding the unguarded-@supports shape to the rejection fixture so it stays caught.

Nothing else to report: stripComments/lineOf/inlineStyles/stylesheets/pages all exist at module scope, the per-stylesheet and per-inline-<style> loops mirror the structure/var() rules above them, and the three loopholes the body names (!important, block-final without ;, SMOOTH) are genuinely closed.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive filed review findings that do not block this PR as backlog items:

• Review backlog (style): Reduced-motion parser is not string-aware, diverging from cssStructureProblems #284 — Review backlog (style): Reduced-motion parser is not string-aware, diverging from cssStructureProblems (Review backlog (style): Reduced-motion parser is not string-aware, diverging from cssStructureProblems #284)

Cap: 10 backlog item(s) per PR per day.

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the diff against the tree at f610ebf and ran it; this looks correct to me.

What I verified:

• unguardedSmoothScroll (scripts/style-contract.test.mjs:390-422) tracks preludes on a brace stack reset on ;/}, so a @supports (scroll-behavior: smooth) { prelude is not mis-read as a declaration (value smooth) ≠ smooth, then the { pushes the full prelude) and [data-scroll-behavior=…] is excluded by the [\w-] look-behind. String skipping mirrors cssStructureProblems.
• Helpers it relies on exist: stripComments (line 63), inlineStyles (line 40), lineOf from scripts/html-pages.mjs:28, stylesheets/pages (lines 672-684).
• node --test scripts/*.test.mjs → 785/785 pass at head, as the body states.
• Mutation: unwrapping the guard at style.css:93 makes the live rule fail with style.css line 93: …, so the extraction kept its teeth (the old inline version would also have missed smooth !important, SMOOTH, and a block-final declaration without ; — the new fixtures cover all three).

Test-only change, no production files touched; scope matches #282.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me. Verified at f610ebf against a fresh clone:

• node --test scripts/*.test.mjs → 785/785 pass.
• unguardedSmoothScroll on the live style.css returns []; with the #281 guard removed it reports style.css line 93 (the body says 92 — the line shifted on main, not a defect).
• blank() (style-contract.test.mjs:25) keeps newlines, so lineOf(clean, i) on the comment-stripped text is accurate.
• The string skip (:396-399) mirrors cssStructureProblems and the content: "{" fixtures prove it keeps the prelude stack honest.
• Diff matches #282's recommendation 1:1; no production files touched.

One low note, not blocking: the guard check (:412) treats any @media prelude containing prefers-reduced-motion: no-preference as guarding, so @media not (prefers-reduced-motion: no-preference) { html { scroll-behavior: smooth; } } passes silently (confirmed by calling the helper). Nothing in the tree writes that today; a follow-up fixture rejecting a not-prefixed query would close it.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#283f610ebf` sha256:34ae065b65022f84114ab3076ae45934e9a49ee145e5b11020ce310666c46e2b — download from the dashboard or `hivectl review evidence #283`.