Skip to content

Review specs and plans in ordinary threads, in any format - #29

Merged
leonlee merged 2 commits into
mainfrom
feature/spec-review
Nov 6, 2026
Merged

leonlee merged 2 commits into
mainfrom
feature/spec-review

Conversation

@leonlee

@leonlee leonlee commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Summary

Step 2 of the plan to take pair beyond code review: spec review that works with any format and changes only the agents' instructions.

  • Author: a spec, plan or design doc in any format (a Markdown plan, an OpenSpec change, an ADR) goes through the normal request. The request lists its paths and commit and includes the format's validator output, such as openspec validate. An implementation request cites the reviewed spec in a ## Spec section: thread ID, paths, approved commit, and what changed since.
  • Reviewer: applies a spec checklist: ambiguity, missing cases, untestable acceptance criteria, scope and feasibility. Approval covers only that version of the spec. On a ## Spec section, the reviewer reads the thread with pair history <id> and reports where the code departs from the spec; if it can't find the thread or the spec, it says so instead of assuming the code conforms.
  • Code: the Claude reviewer's --allowedTools gains pair history, which is read-only and already in REVIEWER_COMMANDS.
  • Compatibility: the message format doesn't change, so older pair versions read these threads normally.

Codex approved it in pair thread 2026-11-06T03-18-42-475Z-a3027a. It noted that the commit in a ## Spec section is only what the author says it is: a Claude reviewer has no git access to check it.

Test plan

  • npm test: 115 pass, including an assertion on the Claude reviewer's allowlist
  • CI on Node 22 and 24

🤖 Generated with Claude Code

leonlee and others added 2 commits November 6, 2026 12:26
The agents' instructions now cover a spec, plan or design doc (a Markdown plan,
an OpenSpec change, an ADR): the request names its paths and commit and any
validator output, and the reviewer applies a spec checklist. An implementation
request can cite the approved thread under ## Spec; the reviewer reads it with
pair history and reports departures, or says it couldn't find them. No message
field changes. The Claude reviewer's allowlist gains pair history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Y3kg5hjT2zSZM9qUEEinM
…ow security note

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Y3kg5hjT2zSZM9qUEEinM
@leonlee
leonlee merged commit 199d23a into main Nov 6, 2026
2 checks passed
@leonlee
leonlee deleted the feature/spec-review branch November 6, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant