Skip to content

Name commands that may have changed unlisted files, and cut opening titles at a word break (#280) - #450

Merged
BunsDev merged 1 commit into
mainfrom
cf7-observations
Oct 30, 2026
Merged

BunsDev merged 1 commit into
mainfrom
cf7-observations

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Fixes the three observations from the CF-7 close-out's live runs (#280, receipt). Val's human review of the saved Notes stays open on #280.

What changes

  • A command that may have changed files no CLI named is now listed (observations 1 and 2).
    • Live, Claude rewrote greeting.txt with printf … > greeting.txt, and the map listed it only as read.
    • Codex edited it with perl -pi, which Codex parses as unknown, so the note had no files section at all.
    • The context map now lists such commands once, under "These commands may have changed files that neither the CLI nor Modex named".
    • It uses the rule that already makes a check stale: not a check, not known read-only, not denied or failed. Modex still guesses no file.
    • The footer and Task view read Files touched · 1, maybe more or Files touched · not listed. The note gains the same section.
    • Records saved earlier reopen unchanged. isTaskSnapshot accepts a missing list and rejects a damaged one.
  • Opening-message titles are cut at a word break (observation 3).
    • Live, the note was titled "…tool available (for".
    • A thread named after its opening message now keeps whole words and graphemes and ends in "…".
    • A Retry still renames a first turn that carries the older 60-character cut.

Tests

  • New unit cases in task-context.test.ts, titles.test.ts and runner.test.ts. A negative control removed the legacy-title match, and the runner case failed.
  • New e2e case in task-to-notes.spec.ts: the Claude redirect turn and the Codex perl -pi turn, in the footer.
  • Local runs on this head:
Suite Result
pnpm build && pnpm test exit 0; desktop 2,071 passed, 20 skipped, 0 failed; every other package green
pnpm test:e2e exit 0; desktop 476 passed, 7 skipped; site 7 passed

Docs: docs/task-context.md (context map), the close-out receipt and docs/status.md ("On main, unreleased").

This is the content for the v0.4.1 patch release, which follows in its own PR.

🤖 Generated with Claude Code

…itles at a word break (#280)

The CF-7 close-out's live runs left three observations. This fixes all three.

- A Claude shell redirect rewrote a file the map listed only as "read", and a Codex `perl -pi`
  edit, parsed as an unknown action, left the note with no files section. The context map now
  lists such commands, once, under "These commands may have changed files that neither the CLI
  nor Modex named". It uses the rule that already makes a check stale and guesses no file. The
  footer and Task view read "N, maybe more" or "not listed". Older saved records reopen unchanged.
- A thread named after its opening message is cut at a word break, by grapheme, with "…". A
  Retry still renames a first turn that carries the older 60-character cut.

Unit, runner, title and e2e regressions cover each; docs/task-context.md, the close-out receipt
and docs/status.md are updated. Val's human review on #280 stays open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 30, 2026 8:54am UTC

Request Review

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage-agent

main 2ce777c cf7-observations 2fffd9c +/-
66% 66% 0%
View coverage of the 3 most impacted files.
File main 2ce777c cf7-observations 2fffd9c +/-
apps/desktop/sr...ngine/runner.ts 98% 98% 0%
apps/desktop/sr...task-context.ts 100% 100% 0%
apps/desktop/sr...ngine/titles.ts 96% 97% +1%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@BunsDev
BunsDev added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 108b814 Oct 30, 2026
13 checks passed
@BunsDev
BunsDev deleted the cf7-observations branch October 30, 2026 10:37
BunsDev added a commit that referenced this pull request Oct 30, 2026
v0.4.1 is a patch release of the CF-7 close-out follow-ups (#450). This bumps the desktop
version to 0.4.1, adds the release review with the local ad-hoc rehearsal, and marks the
candidate in docs/status.md. The Companion stays at 0.4.0 (9).

The packaged rehearsal's one failure, an unexplained stray character in a relaunched
composer draft, passed ten unchanged repetitions and is recorded, not cleared.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BunsDev added a commit that referenced this pull request Nov 1, 2026
* Correct merged PR dates to October 31 UTC (#470)

* docs: point the CF-7 review kit at its restored location (#280) (#473)

The cf7-closeout worktree was pruned after #443 merged, so the receipt's
launch commands pointed at nothing. The saved homes are restored into the
cf7-review-kit worktree from the task-evidence copy, and both saved Task
Notes reopen read-only on a build of 0a8c513. Records the two things a
reviewer will see: the notes predate #450, and the homes name the old
repository path. No human row changes.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
BunsDev added a commit that referenced this pull request Nov 4, 2026
* Correct merged PR dates to October 31 UTC (#470)

* docs: point the CF-7 review kit at its restored location (#280) (#473)

The cf7-closeout worktree was pruned after #443 merged, so the receipt's
launch commands pointed at nothing. The saved homes are restored into the
cf7-review-kit worktree from the task-evidence copy, and both saved Task
Notes reopen read-only on a build of 0a8c513. Records the two things a
reviewer will see: the notes predate #450, and the homes name the old
repository path. No human row changes.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 2fffd9cb Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant