Repository navigation
Expose hosted Cloud message media in TypeScript SDK - #316
Conversation
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 27 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49e5402b0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Local review (head |
Behavior
Hosted Official API history exposes
HistoryMessage.mediaRetrievaland downloads a stored message copy throughMessagingClient.chats.downloadMessageMedia(buffered) ordownloadMessageMediaStream(no buffering, for files up to the API's 32 MiB copy limit). Both encode the session, conversation and opaque message ID and reject client tokens before transport.Contract
GET /messaging/{session}/chats/{conversation}/messages/{messageId}/media(getChatMessageMedia) from API PRs #333 and #385 (merged) is in the SDK snapshot at APIdev29abb7b66a8e225af4df5cf354e9836ccb2ce04c. The coverage ledger flips this row from excluded to covered: 536 operations, 406 covered, 130 excluded.Verification: typecheck, prettier, strict coverage, full suite 127 files / 1,414 tests passed locally.