Skip to content

Expose hosted Cloud message media in TypeScript SDK - #316

Merged
purpshell merged 8 commits into
devfrom
codex/oa08-history-media-sdk
Oct 1, 2026
Merged

purpshell merged 8 commits into
devfrom
codex/oa08-history-media-sdk

Conversation

@purpshell

@purpshell purpshell commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Behavior

Hosted Official API history exposes HistoryMessage.mediaRetrieval and downloads a stored message copy through MessagingClient.chats.downloadMessageMedia (buffered) or downloadMessageMediaStream (no buffering, for files up to the API's 32 MiB copy limit). Both encode the session, conversation and opaque message ID and reject client tokens before transport.

Contract

GET /messaging/{session}/chats/{conversation}/messages/{messageId}/media (getChatMessageMedia) from API PRs #333 and #385 (merged) is in the SDK snapshot at API dev 29abb7b66a8e225af4df5cf354e9836ccb2ce04c. The coverage ledger flips this row from excluded to covered: 536 operations, 406 covered, 130 excluded.

Verification: typecheck, prettier, strict coverage, full suite 127 files / 1,414 tests passed locally.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: b02dcbbf-3570-446d-9335-2c71dcd94186

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd47ea and 744c1ab.

📒 Files selected for processing (7)
  • contracts/README.md
  • contracts/coverage.json
  • packages/typescript/README.md
  • packages/typescript/src/messaging/chats.ts
  • packages/typescript/src/messaging/history.ts
  • packages/typescript/test/coverage.test.ts
  • packages/typescript/test/history.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T22:48:18.388314Z 91fe99f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49e5402b0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/typescript/src/messaging/chats.ts
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 42b2f3075a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 91fe99fade

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@purpshell
purpshell changed the base branch from codex/oa17-marketing-status-sdk to dev October 1, 2026 12:38
@purpshell

Copy link
Copy Markdown
Member Author

Local review (head 744c1ab; manual pass): both methods call assertHistoryCredential before transport, use chatMessagePath encoding, and are GET reads (normal read retry policy is acceptable for an idempotent download). Stream result mirrors media.downloadStream metadata. Ledger row mapping, README and contract text consistent with the 29abb7b snapshot. No findings.

@purpshell
purpshell merged commit a46d2f2 into dev Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant