[vitali87]

Summary

• Adds codebase_rag/tests/test_change_signature_definition.py: the definition's new parameter list (literal types, parameter ordering, special parameters, non-Python refusals) and parameters renamed where the body reads them.
• Tests only: no production code changes.

Demo

No user-visible change: adds the definition and renamed-parameter tests for change_signature.

Type of Change

• Bug fix
• New feature
• Performance improvement
• Refactoring (no functional changes)
• Documentation
• CI/CD or tooling
• Dependencies

None of these applies: the change adds tests only.

Related Issues

Part of #1533 (split from #1912; stack: #2163 → #2161 → #2162 → #2166 → #2164 → #2169 → #2168 → #2165 → #2167).

Test Plan

• Unit tests pass (make test-parallel or uv run pytest -n auto -m "not integration")

• New tests added

• Integration tests pass (make test-integration, requires Docker)

• Manual testing (describe below)

• uv run python -m pytest codebase_rag/tests/test_change_signature_definition.py -p no:randomly -q at 72e529b3e: 21 passed.

• The full suite was not run locally. The CI Unit Tests run at 72e529b3e was cancelled before it finished.

Checklist

• PR title follows Conventional Commits format
• All pre-commit checks pass (make pre-commit)
• No hardcoded strings in non-config/non-constants files
• No # type: ignore, cast(), Any, or object type hints
• New comments and docstrings explain why, not what (see Comment Policy)

SKIP=no-commit-to-branch pre-commit run --from-ref 7adfaa747 --to-ref 72e529b3e (ruff, ruff-format, ty, bandit, generate-readme and the file hygiene hooks): passed. The unit-suite step of make pre-commit was not run locally.

Unchecked items:

• The tests write their fixture source and expected text inline rather than through constants.
• test_change_signature_definition.py has one # type: ignore[no-untyped-def] and a dict[str, object] hint, both on the both_sites test stub.
• Comments were not re-audited against the policy in this pass.

---

Files changed

• codebase_rag/tests/test_change_signature_definition.py

Diff stats

+365 additions, -0 deletions (365 LOC)

Dependencies

This PR depends on: pr-7

Dependency graph

Merge in this order:

pr-1: feat(signature): contract expectation, shared call-site helpers and constants for change_signature (#1533, 1/9)
└── pr-2: feat(signature): parameter specs, mapping sources and the change_signature contract check (#1533, 2/9)
    └── pr-3: feat(signature): read the header, bind call arguments, render the rewrite (#1533, 3/9)
        └── pr-4: feat(signature): the change_signature operation (#1533, 4/9)
            └── pr-5: feat(signature): expose change_signature through the CLI and MCP, with docs (#1533, 5/9)
                └── pr-6: test(signature): acceptance, transaction and MCP tests for change_signature (#1533, 6/9)
                    └── pr-7: test(signature): mapping tests for change_signature (#1533, 7/9)
                        └── pr-8: test(signature): definition and renamed-parameter tests for change_signature (#1533, 8/9)  <-- this PR
                            └── pr-9: test(signature): hierarchy, receiver and default guards for change_signature (#1533, 9/9)

Summary by CodeRabbit

• Tests
  • Expanded automated checks for editing function signatures, including parameter defaults, ordering, and special parameter forms.
  • Added coverage for renaming parameters in function bodies, handling conflicts and nested scopes, and updating nested calls.
  • Added checks for unsupported or unknown definitions, reingestion after edits, and end-to-end smoke-test results.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: vitali87/code-graph-rag
• Branch: pr-split/split-1912-change-signature/pr-8
• File: .coderabbit.yaml
• Commit: 944b73c
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: 6cb21255-638c-4ce2-afbf-a7063ee5ddea

Commits

Reviewing files that changed from the base of the PR and between 0305c5c and 944b73c.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: vitali87/code-graph-rag/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 198fbcc7-9aa0-48c5-983a-608df96d40d3

📥 Commits

Reviewing files that changed from the base of the PR and between 2d92155 and 7ad8ae2.

📒 Files selected for processing (1)

• codebase_rag/tests/test_change_signature_definition.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review.

Walkthrough

Adds tests for signature definition edits. The tests cover validation rules, parameter renaming in function bodies, and applied rewrites to recursive and nested calls.

Changes: Signature Change Tests

Layer / File(s)	Summary
Definition validation codebase_rag/tests/test_change_signature_definition.py	Adds tests for default and annotation compatibility, parameter ordering, supported definition forms, and unknown definitions.
Parameter renaming codebase_rag/tests/test_change_signature_definition.py	Adds dry-run tests for body-reference updates, name swaps, and refusal cases involving nested scopes or existing names.
Applied call-site rewrites codebase_rag/tests/test_change_signature_definition.py	Adds tests for recursive and nested call rewrites, including reingestion, site counts, and runtime results.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: Minimal · previous review 7ad8a

This PR only adds regression tests for change_signature and does not alter runtime behavior. No merge-blocking risk was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies tests for change_signature definition edits and renamed parameters. It is specific and aligned with the pull request changes.
Description check		The description includes the required summary, demo, change type, related issues, test plan, checklist, changed files, and dependency details. It also clearly records the tests that passed and the che…

Full details: Description check

Explanation

The description includes the required summary, demo, change type, related issues, test plan, checklist, changed files, and dependency details. It also clearly records the tests that passed and the checks that were not run.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vitali87]

Unit Tests (macos-latest, py3.12) was cancelled by its 30-minute job cap partway through the test run (run 37213378959), which also fails All Checks Pass. GitHub had roughly 400 CI runs queued across this repo at the time, and this branch passed the same job before the restack, so I read it as a slow runner rather than a hang in this PR. I have re-run the failed jobs once.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud