[vitali87]

Summary

• Adds codebase_rag/tests/change_signature_support.py, the shared fixture project and helpers the later test layers (test(signature): mapping tests for change_signature (#1533, 7/9) #2168, test(signature): definition and renamed-parameter tests for change_signature (#1533, 8/9) #2165, test(signature): hierarchy, receiver and default guards for change_signature (#1533, 9/9) #2167) build on.
• Adds codebase_rag/tests/test_change_signature.py: the acceptance scenarios, the dry-run, undo and contract-rollback tests, and the MCP tool tests.
• Tests only: no production code changes.

Demo

No user-visible change: adds the acceptance, transaction and MCP tests for change_signature, and their shared fixture.

Type of Change

• Bug fix
• New feature
• Performance improvement
• Refactoring (no functional changes)
• Documentation
• CI/CD or tooling
• Dependencies

None of these applies: the change adds tests only.

Related Issues

Part of #1533 (split from #1912; stack: #2163 → #2161 → #2162 → #2166 → #2164 → #2169 → #2168 → #2165 → #2167).

Test Plan

• Unit tests pass (make test-parallel or uv run pytest -n auto -m "not integration")

• New tests added

• Integration tests pass (make test-integration, requires Docker)

• Manual testing (describe below)

• uv run python -m pytest codebase_rag/tests/test_change_signature.py -p no:randomly -q at fa9969c18: 10 passed.

• The full suite was not run locally. The CI Unit Tests run at fa9969c18 was cancelled before it finished.

Checklist

• PR title follows Conventional Commits format
• All pre-commit checks pass (make pre-commit)
• No hardcoded strings in non-config/non-constants files
• No # type: ignore, cast(), Any, or object type hints
• New comments and docstrings explain why, not what (see Comment Policy)

SKIP=no-commit-to-branch pre-commit run --from-ref 09c5ae4f4 --to-ref fa9969c18 (ruff, ruff-format, ty, bandit, generate-readme and the file hygiene hooks): passed. The unit-suite step of make pre-commit was not run locally.

Unchecked items:

• The tests write their fixture source and expected text inline rather than through constants.
• Comments were not re-audited against the policy in this pass.

---

Files changed

• codebase_rag/tests/change_signature_support.py
• codebase_rag/tests/test_change_signature.py

Diff stats

+425 additions, -0 deletions (425 LOC)

Dependencies

This PR depends on: pr-5

Dependency graph

Merge in this order:

pr-1: feat(signature): contract expectation, shared call-site helpers and constants for change_signature (#1533, 1/9)
└── pr-2: feat(signature): parameter specs, mapping sources and the change_signature contract check (#1533, 2/9)
    └── pr-3: feat(signature): read the header, bind call arguments, render the rewrite (#1533, 3/9)
        └── pr-4: feat(signature): the change_signature operation (#1533, 4/9)
            └── pr-5: feat(signature): expose change_signature through the CLI and MCP, with docs (#1533, 5/9)
                └── pr-6: test(signature): acceptance, transaction and MCP tests for change_signature (#1533, 6/9)  <-- this PR
                    └── pr-7: test(signature): mapping tests for change_signature (#1533, 7/9)
                        └── pr-8: test(signature): definition and renamed-parameter tests for change_signature (#1533, 8/9)
                            └── pr-9: test(signature): hierarchy, receiver and default guards for change_signature (#1533, 9/9)

Summary by CodeRabbit

• Tests
  • Expanded coverage for changing function signatures, including adding and reordering parameters while accounting for positional and keyword callers.
  • Added checks for dry-run behavior, transaction history, rollback when a caller is invalid, and handling of heuristic-resolved call sites.
  • Added validation of the MCP tool’s schema, responses, and refusal behavior.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: vitali87/code-graph-rag
• Branch: pr-split/split-1912-change-signature/pr-6
• File: .coderabbit.yaml
• Commit: eac8482
• Layers: Repository YAML
• Review profile: QUIET
• Plan: Advanced
• Run ID: f453f1ac-dfb5-4885-a7b1-6389c4b9c9a4

Commits

Reviewing files that changed from the base of the PR and between fddc17c and eac8482.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: vitali87/code-graph-rag/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: b01adb2b-f95a-4d6c-a6fe-5070545ec37c

📥 Commits

Reviewing files that changed from the base of the PR and between 4ba9c3f and 712c700.

📒 Files selected for processing (2)

• codebase_rag/tests/change_signature_support.py
• codebase_rag/tests/test_change_signature.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

Walkthrough

This change adds shared indexed-project test fixtures and integration tests for signature changes. The tests cover parameter mapping and reordering, heuristic call-site handling, dry-run and transaction behavior, rollback after contract failure, and MCP tool responses.

Changes: Signature Change Test Coverage

Layer / File(s)	Summary
Indexed project fixture codebase_rag/tests/change_signature_support.py	Adds a Python fixture project, helpers to write and index it, a subprocess smoke test, and a helper to set a call-edge resolution.
Signature mapping and call-site tests codebase_rag/tests/test_change_signature.py	Tests mapped parameter insertion, parameter reordering, and how heuristic-resolved call sites are handled by default and when allow_heuristic=True.
Transaction and MCP tests codebase_rag/tests/test_change_signature.py	Tests dry-run and transaction history behavior, rollback after re-ingestion finds an invalid caller, and MCP schema, response, and refusal behavior.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: Minimal · previous review 712c7

This change adds test coverage for signature changes, dry runs, rollback, and MCP responses. It does not alter production behavior, and no actionable merge risk was found.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the acceptance, transaction, and MCP tests for change_signature and follows the repository's Conventional Commits format.
Description check		The description follows the required template and documents the scope, lack of user-visible changes, related issue, test coverage, executed commands, and known test limitations.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

pr-split analysis

Metric	Value
Total LOC	425
Files changed	2
Suggested groups	2
Largest group	331 LOC
LOC overflow	0
File scatter	0

This PR has 425 LOC and could be split into 2 smaller PRs:

Group	Title	Diff	Depends On	Files
pr-1	chore(split): review test-change-signature-1	+331/-0	—	codebase_rag/tests/test_change_signature.py
pr-2	chore(split): review change-signature-support-2	+94/-0	—	codebase_rag/tests/change_signature_support.py

Run pr-split split locally to create these sub-PRs, or adjust --max-loc to change the target size.

[vitali87]

Unit Tests (macos-latest, py3.13, shard 1/2) failed on 7b24eb6 with one setup error, in test_language_source_checkout.py::TestInstalledCgrRefuses::test_refusal_is_printed_once. The fixture's git commit -q -m init died with SIGTRAP; the other 11,569 tests in the shard passed.

This isn't caused by this PR. Its diff only adds change_signature_support.py and test_change_signature.py. The failing test and conftest.py are identical to main's, and the error is the runner's own git process crashing, not an assertion. No fix exists, since nothing in the code fails. I'll re-run the failed job once when the run finishes.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vitali87]

@greptile review

[greptile-apps]

Confidence Score: 5/5

[Low impact] This tests-only PR appears safe to merge.

Summary

Adds shared fixtures and 10 tests for change_signature.

• Signature edit tests check added and reordered parameters against callers.
• Signature edit tests make guessed call sites visible unless callers opt in.
• Signature edit tests check preview, history, and rollback outcomes.
• MCP signature tests check previews and refusal payloads.

_{Reviews (1) · Last reviewed commit: "test(signature): acceptance, transaction..." · Reviewed by Greptile}